Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify check for writing errors to ErrorOutput #983

Merged
merged 2 commits into from Jul 30, 2021

Conversation

lancoLiu
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #983 (b0d2b84) into master (1cac10b) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #983      +/-   ##
==========================================
- Coverage   98.20%   98.10%   -0.10%     
==========================================
  Files          46       46              
  Lines        2057     2056       -1     
==========================================
- Hits         2020     2017       -3     
- Misses         29       30       +1     
- Partials        8        9       +1     
Impacted Files Coverage Δ
zapcore/entry.go 93.75% <100.00%> (-0.08%) ⬇️
zapcore/sampler.go 96.22% <0.00%> (-3.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cac10b...b0d2b84. Read the comment docs.

Copy link
Collaborator

@prashantv prashantv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the simplification!

zapcore/entry.go Outdated Show resolved Hide resolved
@prashantv prashantv changed the title Optimize the code Simplify check for writing errors to ErrorOutput Jul 29, 2021
@prashantv
Copy link
Collaborator

Thanks for the contribution @lancoLiu

@prashantv prashantv merged commit 81879d1 into uber-go:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants