Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo #967

Merged
merged 1 commit into from Jun 16, 2021
Merged

fix typo #967

merged 1 commit into from Jun 16, 2021

Conversation

heyanfu
Copy link
Contributor

@heyanfu heyanfu commented Jun 16, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jun 16, 2021 •
edited

Codecov Report

Merging #967 (e901bae) into master (aa3e73e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #967   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files          45       45           
  Lines        2020     2020           
=======================================
  Hits         1983     1983           
  Misses         29       29           
  Partials        8        8
Impacted Files Coverage Δ
zaptest/observer/observer.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa3e73e...e901bae. Read the comment docs.

prashantv
prashantv approved these changes Jun 16, 2021
View reviewed changes
Copy link
Collaborator

@prashantv prashantv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix

@sywhang sywhang merged commit 0c42722 into uber-go:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashantv prashantv prashantv approved these changes

@sywhang sywhang sywhang approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heyanfu @prashantv @sywhang