Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Travis to GitHub Actions. #940

Merged
merged 1 commit into from May 17, 2021
Merged

Switch from Travis to GitHub Actions. #940

merged 1 commit into from May 17, 2021

Conversation

shirchen
Copy link
Contributor

Since we are deprecating Travis CI usage for OSS, we need to switch to GitHub Actions. Note this change, unfortunately, removes ppc64le from list of architectures as this is not supported by GH-hosted runners listed here: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#github-hosted-runners

cc @genisysram who added ppc64le arch in #872.

@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #940 (3087fe0) into master (7b21229) will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #940      +/-   ##
==========================================
- Coverage   98.27%   98.02%   -0.26%     
==========================================
  Files          44       44              
  Lines        1974     1974              
==========================================
- Hits         1940     1935       -5     
- Misses         27       30       +3     
- Partials        7        9       +2     
Impacted Files Coverage Δ
internal/ztest/timeout.go 54.54% <0.00%> (-27.28%) ⬇️
zapcore/sampler.go 96.15% <0.00%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b21229...3087fe0. Read the comment docs.

@abhinav abhinav merged commit d9a4dcc into master May 17, 2021
@abhinav abhinav deleted the travis_to_gh branch May 17, 2021 22:17
abhinav pushed a commit that referenced this pull request May 25, 2021
We're deprecating use of Travis for our OSS projects, so switch to
GitHub Actions for it.

Unfortunately, this required dropping tests we had against ppc64le
because [GitHub Workflows doesn't support it][1].

  [1]: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#github-hosted-runners
@abhinav abhinav mentioned this pull request Nov 5, 2021
abhinav added a commit that referenced this pull request Nov 5, 2021
Changes made in #752, #883, and #940 were not carried over.
abhinav added a commit that referenced this pull request Nov 5, 2021
This change updates dependencies for all unpublished submodules of Zap
(benchmarks and zapgrpc/test).
Note that we do not update the minimum dependencies for Zap itself.
We don't need newer versions of any dependency than Zap currently uses.

We update the benchmark numbers in the README
by running `make updatereadme`.
That uses .readme.tmpl to generate the README,
but the template was not updated
when we changed the README in #752, #883, and #940.
So this change also updates the README template.

Supersedes #992
Ref GO-986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants