Unexpected memory usage

[wyxloading]

Here cloned a jsonEncoder (which actually get from _jsonPool), but never put back to _jsonPool after use.

zap/zapcore/console_encoder.go

Lines 131 to 145 in 53a3870

	func (c consoleEncoder) writeContext(line *buffer.Buffer, extra []Field) {
	context := c.jsonEncoder.Clone().(*jsonEncoder)
	defer context.buf.Free()
	addFields(context, extra)
	context.closeOpenNamespaces()
	if context.buf.Len() == 0 {
	return
	}
	c.addSeparatorIfNecessary(line)
	line.AppendByte('{')
	line.Write(context.buf.Bytes())
	line.AppendByte('}')
	}

Perhaps we need something like below to decrease memory allocations.

context := c.jsonEncoder.Clone().(*jsonEncoder) 
defer func() {
    context.buf.Free()
    putJSONEncoder(context)
}

[prashantv]

From a quick glance, this seems reasonable. Can you send a PR, and ensure the race detector doesn't find any issues once the above change is made. Thanks!

[wyxloading]

I would like to send PR for this (FYI, PR link #852)

[abhinav]

#852 was merged so we can resolve this.