Open absolute paths as files, limited Windows support #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1159 +/- ##
==========================================
+ Coverage 98.24% 98.34% +0.09%
==========================================
Files 49 49
Lines 2165 2169 +4
==========================================
+ Hits 2127 2133 +6
+ Misses 29 28 -1
+ Partials 9 8 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
abhinav
approved these changes
Sep 9, 2022
This makes it easier to test sinkRegistry functionality that registers temporary sinks, and in future, stubbing of the os.OpenFile call.
This avoids a dependency on the underlying filesystem, which avoids unnecessarily trying to open files when we just want to ensure that paths are opened using the file sink.
Windows absolute paths such as `c:\log.json` parse as URLs with the scheme set. The sink registry currently expects file paths to either have a `file` scheme, or no scheme. Rather than trying to special-case drives in schemes, and reassemble paths, simplify by checking for `filepath.IsAbs` before parsing the path as a URL. Since `filepath.IsAbs` is OS-specific, windows paths will not be treated as absolute paths on other systems, and will still work using any registered sink factories.
prashantv
force-pushed
the
prashantv/zap-win-abs
branch
from
9802e6a
to
ffd9b49
Compare
|
Thanks for the suggestions, updated to incorporate them. |
prashantv
force-pushed
the
prashantv/zap-win-abs
branch
from
ffd9b49
to
15c26e5
Compare
abhinav
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #994, #1000
Alternate approach to #999, this approach brings absolute path support to Windows.
It does so by checking for absolute paths and handling them using the file factory directly.
To test different paths without trying to actually open them (UNC paths hit the network), this change also
prefactors the sink registry into a separate type that allows stubbing of the
os.OpenFilecall.Note: This change does not bring full Windows support -- many tests still fail, and Windows file URIs don't work.