Wrap Open error and update TestOpen to check for fs.ErrNotExist #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a prefactor for Windows support (uber-go#621). `TestOpen` currently relies on a hardcoded error "no such file or directory" if a file is not found. However, this error message is OS-specific. We can now rely on `errors.Is(err, fs.ErrNotExist)` if we wrap errors using `%w` instead of `%v`.
Codecov Report
@@ Coverage Diff @@
## master #1149 +/- ##
=======================================
Coverage 98.32% 98.32%
=======================================
Files 49 49
Lines 2146 2146
=======================================
Hits 2110 2110
Misses 28 28
Partials 8 8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
abhinav
approved these changes
Aug 16, 2022
ErrorContains doesn't exist in 1.7.0.
Per [Error Strings][1] guidance, don't add a "couldn't do foo" or "failed to do bar" to error messages when wrapping. [1]: https://github.com/uber-go/guide/blob/master/style.md#error-wrapping This is to prevent long chains of "failed to x: failed to y: .." as these errors tend to get wrapped before they're presented to the user.
Avoid too many branches in the table test in favor of simpler single purpose tables: - one for success - one for not found errors - one for other errors matched by message
abhinav
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prefactor for Windows support (#621).
TestOpencurrently relies on a hardcoded error "no such file ordirectory" if a file is not found. However, this error message is
OS-specific. We can now rely on
errors.Is(err, fs.ErrNotExist)if we wrap errors using
%winstead of%v.