Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Don't run benchmarks #1029

Merged
merged 1 commit into from Nov 19, 2021
Merged

CI: Don't run benchmarks #1029

merged 1 commit into from Nov 19, 2021

Conversation

abhinav
Copy link
Collaborator

@abhinav abhinav commented Nov 19, 2021

We don't need to run benchmarks in CI,
especially because it's difficult to get consistent numbers out of it.

We're experimenting with Bencher for
continuous benchmarking.

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #1029 (5ec8927) into master (aea2a50) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 5ec8927 differs from pull request most recent head e2d3bef. Consider uploading reports for the commit e2d3bef to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1029   +/-   ##
=======================================
  Coverage   98.20%   98.20%           
=======================================
  Files          47       47           
  Lines        2067     2067           
=======================================
  Hits         2030     2030           
  Misses         29       29           
  Partials        8        8           
Impacted Files Coverage Δ
writer.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aea2a50...e2d3bef. Read the comment docs.

@abhinav abhinav merged commit 10b1fe4 into master Nov 19, 2021
@abhinav abhinav deleted the abg/trigger-benchmark branch November 19, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants