From 3306b8c5a15fd7fda6ca98868c599fe4c5095171 Mon Sep 17 00:00:00 2001 From: Koichi Shiraishi Date: Wed, 16 Jun 2021 15:12:04 +0900 Subject: [PATCH] zapcore: add called Stop twice testcase Signed-off-by: Koichi Shiraishi --- zapcore/buffered_write_syncer_test.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/zapcore/buffered_write_syncer_test.go b/zapcore/buffered_write_syncer_test.go index 9c28076bb..72d4d6f88 100644 --- a/zapcore/buffered_write_syncer_test.go +++ b/zapcore/buffered_write_syncer_test.go @@ -53,6 +53,14 @@ func TestBufferWriter(t *testing.T) { assert.Equal(t, "foo", buf.String(), "Unexpected log string") }) + t.Run("stop twice", func(t *testing.T) { + ws := &BufferedWriteSyncer{WS: &ztest.FailWriter{}} + _, err := ws.Write([]byte("foo")) + require.NoError(t, err, "Unexpected error writing to WriteSyncer.") + assert.Error(t, ws.Stop(), "Expected stop to fail.") + assert.NoError(t, ws.Stop(), "Expected stop to not fail.") + }) + t.Run("wrap twice", func(t *testing.T) { buf := &bytes.Buffer{} bufsync := &BufferedWriteSyncer{WS: AddSync(buf)}