AppendInvoke: Merge test, real example #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests for AppendInvoke with Close duplicate the tests for AppendInvoke. These can be merged, and the unit tests for Close only need to verify whether the Invoker returned by multierr.Close calls the Close function in the provided io.Closer.
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 105 105
=========================================
Hits 105 105 Continue to review full report at Codecov.
|
This replaces the example included with AppendInvoke with a more realistic example. The trade-off here is that although this example is more realistic, it has no output to assert.
prashantv
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements some suggestions made in #47. In particular,
Example screenshot in godocs:
