tools: Switch golint to revive #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revive is a drop-in replacement for golint that's faster. Setting up a basic configuration that we can be tweaked going forward.
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
=======================================
Coverage 94.92% 94.92%
=======================================
Files 5 5
Lines 138 138
=======================================
Hits 131 131
Misses 4 4
Partials 3 3 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
moisesvega
approved these changes
Feb 6, 2023
abhinav
added a commit
to uber-go/zap
that referenced
this pull request
Feb 17, 2023
golint is no longer maintained. Switch to revive which is a near drop-in replacement. This is also what goleak did (uber-go/goleak#97). Includes fixes for the following: ``` internal/level_enabler.go:21:1: should have a package comment zapio/writer.go:21:1: should have a package comment zapgrpc/internal/test/grpc.go:21:1: should have a package comment internal/readme/readme.go:21:1: should have a package comment field_test.go:70:17: should omit type bool from declaration of var boolVal; it will be inferred from the right-hand side field_test.go:71:17: should omit type complex128 from declaration of var complex128Val; it will be inferred from the right-hand side field_test.go:73:17: should omit type time.Duration from declaration of var durationVal; it will be inferred from the right-hand side field_test.go:74:17: should omit type float64 from declaration of var float64Val; it will be inferred from the right-hand side field_test.go:76:17: should omit type int from declaration of var intVal; it will be inferred from the right-hand side field_test.go:81:17: should omit type string from declaration of var stringVal; it will be inferred from the right-hand side field_test.go:82:17: should omit type time.Time from declaration of var timeVal; it will be inferred from the right-hand side ```
abhinav
added a commit
to uber-go/zap
that referenced
this pull request
Feb 17, 2023
golint is no longer maintained. Switch to revive which is a near drop-in replacement. This is also what goleak did (uber-go/goleak#97). Includes fixes for the following: ``` internal/level_enabler.go:21:1: should have a package comment zapio/writer.go:21:1: should have a package comment zapgrpc/internal/test/grpc.go:21:1: should have a package comment internal/readme/readme.go:21:1: should have a package comment field_test.go:70:17: should omit type bool from declaration of var boolVal; it will be inferred from the right-hand side field_test.go:71:17: should omit type complex128 from declaration of var complex128Val; it will be inferred from the right-hand side field_test.go:73:17: should omit type time.Duration from declaration of var durationVal; it will be inferred from the right-hand side field_test.go:74:17: should omit type float64 from declaration of var float64Val; it will be inferred from the right-hand side field_test.go:76:17: should omit type int from declaration of var intVal; it will be inferred from the right-hand side field_test.go:81:17: should omit type string from declaration of var stringVal; it will be inferred from the right-hand side field_test.go:82:17: should omit type time.Time from declaration of var timeVal; it will be inferred from the right-hand side ```
abhinav
added a commit
to uber-go/zap
that referenced
this pull request
Feb 17, 2023
golint is no longer maintained. Switch to revive which is a near drop-in replacement. This is also what goleak did (uber-go/goleak#97). Includes fixes for the following: ``` internal/level_enabler.go:21:1: should have a package comment zapio/writer.go:21:1: should have a package comment zapgrpc/internal/test/grpc.go:21:1: should have a package comment internal/readme/readme.go:21:1: should have a package comment field_test.go:70:17: should omit type bool from declaration of var boolVal; it will be inferred from the right-hand side field_test.go:71:17: should omit type complex128 from declaration of var complex128Val; it will be inferred from the right-hand side field_test.go:73:17: should omit type time.Duration from declaration of var durationVal; it will be inferred from the right-hand side field_test.go:74:17: should omit type float64 from declaration of var float64Val; it will be inferred from the right-hand side field_test.go:76:17: should omit type int from declaration of var intVal; it will be inferred from the right-hand side field_test.go:81:17: should omit type string from declaration of var stringVal; it will be inferred from the right-hand side field_test.go:82:17: should omit type time.Time from declaration of var timeVal; it will be inferred from the right-hand side ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #92.
Revive is a drop-in replacement for golint that's faster.
Setting up a basic configuration that we can be tweaked going forward.