Move tools dependencies into subdirectory with tag #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid tools dependencies in goleak's go.mod. golint is deprecated, we can separately migrate to another tool, but the tools change avoids any CI-time dependency from leaking into our go.mod.
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
=======================================
Coverage 94.92% 94.92%
=======================================
Files 5 5
Lines 138 138
=======================================
Hits 131 131
Misses 4 4
Partials 3 3 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sywhang
approved these changes
Feb 6, 2023
liggitt
reviewed
Feb 6, 2023
| @@ -0,0 +1,7 @@ | |||
| module go.uber.org/goleak | |||
There was a problem hiding this comment.
thanks for isolating the golang.org/x/lint dependency, much appreciated
I'm not sure this matters, but having two go.mod files claim to be the same module name is a little weird... should this be go.uber.org/goleak/tools or something?
There was a problem hiding this comment.
It should be, good catch! Will fix this as part of migrating off golint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92.
Avoid tools dependencies in goleak's go.mod.
golint is deprecated, we can separately migrate to another tool, but the tools change avoids any CI-time dependency from leaking into our go.mod.