Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friction for tinygo users #71

Open
dkegel-fastly opened this issue Jan 21, 2022 · 0 comments · May be fixed by #72
Open

Friction for tinygo users #71

dkegel-fastly opened this issue Jan 21, 2022 · 0 comments · May be fixed by #72

Comments

@dkegel-fastly
Copy link

dkegel-fastly commented Jan 21, 2022

tinygo as of release 0.22 does not support goleak; this isn't particularly surprising, as tinygo still only provides stubs for several things goleak relies upon.

A number of apps - particularly, the one I'm trying to ship :-) - would pass tests under both go and tinygo if goleak sensed the tinygo build constraint and provided a minimal stub while tinygo matures.

This would be an elegant way to reduce friction for goleak users who must pass tests with both go and tinygo.

I'll provide a pull request with the simple change required. I think this is sufficient; works for my app, at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant