Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect documentation on soft value group #932

Merged
merged 1 commit into from Aug 24, 2022

Conversation

sywhang
Copy link
Contributor

@sywhang sywhang commented Aug 24, 2022

No description provided.

@sywhang sywhang requested a review from abhinav August 24, 2022 17:49
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #932 (c94f921) into master (5566339) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #932   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files          30       30           
  Lines        1337     1337           
=======================================
  Hits         1320     1320           
  Misses         11       11           
  Partials        6        6           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@abhinav abhinav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provides aren't annotated or using fx.Out so they won't go to the group.

@sywhang
Copy link
Contributor Author

sywhang commented Aug 24, 2022

yeah, realized the code sample was broken too after pushing this - updated it.

Copy link
Contributor

@r-hang r-hang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sywhang sywhang merged commit a3d266e into uber-go:master Aug 24, 2022
@sywhang sywhang deleted the fix-doc branch August 24, 2022 18:32
Copy link
Collaborator

@abhinav abhinav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retroactive lgtm

sywhang added a commit to sywhang/fx that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants