Fix Invoke order when fx.Module is used #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #925 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 30 30
Lines 1332 1332
=======================================
Hits 1315 1315
Misses 11 11
Partials 6 6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Currently, fx.Module's invokes are run after all the invokes provided at the parent level are invoked. This makes it difficult for module consumers to control the precise invoke orders. This changes the invoke order to run all the invokes in the child module before running any of the invokes in the parent module, and clarify that order in the documentation for Invoke. Solves uber-go#918. Refs GO-1591.
sywhang
added a commit
to sywhang/fx
that referenced
this pull request
Oct 11, 2022
* Fix Invoke order when fx.Module is used Currently, fx.Module's invokes are run after all the invokes provided at the parent level are invoked. This makes it difficult for module consumers to control the precise invoke orders. This changes the invoke order to run all the invokes in the child module before running any of the invokes in the parent module, and clarify that order in the documentation for Invoke. Solves uber-go#918. Refs GO-1591. * fix indentation in code sample
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, fx.Module's invokes are run after all the invokes provided
at the parent level are invoked.
This makes it difficult for module consumers to control the precise
invoke orders.
This changes the invoke order to run all the invokes in the child
module before running any of the invokes in the parent module, and
clarify that order in the documentation for Invoke.
Solves #918.
Refs GO-1591.