Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs change for soft value groups #913

Merged
merged 2 commits into from Aug 5, 2022
Merged

Conversation

sywhang
Copy link
Contributor

@sywhang sywhang commented Aug 5, 2022

This modifies some wordings in the docs for soft value groups and
adds some clarifications.

@sywhang sywhang requested review from abhinav and EstebanOlmedo and removed request for abhinav August 5, 2022 17:57
This modifies some wordings in the docs for soft value groups and
adds some clarifications.
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #913 (61f5c31) into master (1124297) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #913   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          30       30           
  Lines        1328     1328           
=======================================
  Hits         1311     1311           
  Misses         11       11           
  Partials        6        6           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

inout.go Show resolved Hide resolved
Copy link
Collaborator

@EstebanOlmedo EstebanOlmedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine for me, just left a comment about a clarification.

@sywhang sywhang merged commit 2833ddf into uber-go:master Aug 5, 2022
@sywhang sywhang deleted the soft-doc branch August 5, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants