Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go 1.19 / Remove deprecated API usage #910

Merged
merged 4 commits into from Aug 4, 2022
Merged

Conversation

sywhang
Copy link
Contributor

@sywhang sywhang commented Aug 3, 2022

Go 1.19 is out. Let's use it in the CI.

Also, this updates staticcheck version and removes deprecated API usage.

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #910 (f71dbc8) into master (2051fa4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #910   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          30       30           
  Lines        1328     1328           
=======================================
  Hits         1311     1311           
  Misses         11       11           
  Partials        6        6           
Impacted Files Coverage Δ
annotated.go 99.69% <ø> (ø)
app.go 95.04% <ø> (ø)
decorate.go 100.00% <ø> (ø)
internal/fxreflect/stack.go 100.00% <ø> (ø)
provide.go 100.00% <ø> (ø)
replace.go 100.00% <ø> (ø)
supply.go 100.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@abhinav
Copy link
Collaborator

abhinav commented Aug 3, 2022

need to run gofmt

@sywhang
Copy link
Contributor Author

sywhang commented Aug 3, 2022

Interesting. Looks like staticcheck is somehow crashing? looking into it now

@sywhang sywhang changed the title CI: Use Go 1.19 Use Go 1.19 / Remove deprecated API usage Aug 3, 2022
@sywhang sywhang merged commit d88feb8 into uber-go:master Aug 4, 2022
@sywhang sywhang deleted the use-119 branch August 4, 2022 00:26
EstebanOlmedo pushed a commit that referenced this pull request Aug 4, 2022
Go 1.19 is out. Let's use it in the CI.

Also, this updates staticcheck version and removes deprecated API usage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants