New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module info to fxevent #863
Conversation
This adds the module info in the fxevent Provided/Decorated/Invoked structs to make the logs more descriptive by including which module each of these happened from. This can be helpful especially for debugging decorates, since the module from which decoration is applied changes the results.
Codecov Report
@@ Coverage Diff @@
## master #863 +/- ##
==========================================
+ Coverage 98.45% 98.49% +0.04%
==========================================
Files 30 30
Lines 1100 1130 +30
==========================================
+ Hits 1083 1113 +30
Misses 11 11
Partials 6 6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some suggestions
Fix the format call for `Supplied` event. Previously, `\n%!(EXTRA string=)` was appended to `SUPPLY` logs when `ModuleName` was empty. Add tests to ensure format string contains the same number of verbs as there are arguments when logging an `Event` using `ConsoleLogger` for all relevant event types, Module info was added to fxevent in uber-go#863.
Fix the format call for `Supplied` event. Previously, `\n%!(EXTRA string=)` was appended to `SUPPLY` logs when `ModuleName` was empty. Add tests to ensure format string contains the same number of verbs as there are arguments when logging an `Event` using `ConsoleLogger` for all relevant event types, Module info was added to fxevent in #863.
This adds the module info in the fxevent Provided/Decorated/Invoked
structs to make the logs more descriptive by including which module
each of these happened from.
This can be helpful especially for debugging decorates, since the
module from which decoration is applied changes the results.
Fix #855.
Refs GO-1285.