doc: Expand and organize Decorate documentation #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This elaborates on the documentation for fx.Decorate with more examples, and organizes it into two sections: - Decorator functions, enumerating the various signatures a decorator function can have - Decorator scope, explaining how decorator changes are scoped Added demonstrative examples for everything. In the future, we can turn some of these into example tests. Refs GO-1254
Codecov Report
@@ Coverage Diff @@
## master #858 +/- ##
==========================================
- Coverage 98.63% 98.45% -0.19%
==========================================
Files 30 30
Lines 1100 1100
==========================================
- Hits 1085 1083 -2
- Misses 10 11 +1
- Partials 5 6 +1
Continue to review full report at Codecov.
|
sywhang
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This elaborates on the documentation for fx.Decorate with more examples,
and organizes it into two sections:
function can have
Added demonstrative examples for everything.
In the future, we can turn some of these into example tests.
Refs GO-1254
Preview:
