Modify non compliant decoration test #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a test that was added in a previous commit which highlights a problematic transitive decoration of a parent-module provided-type. Specifically, consider the following case. Parent Module provides type A, and type B which depends on type A. Child Module decorates type A and invokes something that depends on type B. In such case, the invoked function in child Module should not see a version of type B created with a decorated type A. This is because the constructor for the type B lives outside the scope of the decoration. The decoration can only affect child Scope's providers, and should not affect parent-provided constructor directly. This test case is not compliant with such case, so it should be modified.
Codecov Report
@@ Coverage Diff @@
## master #851 +/- ##
=======================================
Coverage 98.45% 98.45%
=======================================
Files 30 30
Lines 1100 1100
=======================================
Hits 1083 1083
Misses 11 11
Partials 6 6 Continue to review full report at Codecov.
|
abhinav
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies a test that was added in a previous commit which highlights
a problematic transitive decoration of a parent-module provided-type.
Specifically, consider the following case:
In such case, the invoked function in child Module should not see a version of
type B created with a decorated type A.
This is because the constructor for the type B lives outside the scope of the
decoration. The decoration can only affect child Scope's providers, and should
not affect parent-provided constructor directly.
This test case is not compliant with such case, so it should be modified.
This also pins Dig dependency to latest commit of Dig's master branch to take
in the fix made in uber-go/dig#325.