Add more Fx.Decorate tests #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds more cases of fx.Decorate tests, specifically for transitive dependencies that are decorated. For example, when a function depends on type A whose constructor depends on type B, and B has a decorator associated with it, we expect type A's constructor to use the decorated value of B in its constructor.
Codecov Report
@@ Coverage Diff @@
## master #846 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 30 30
Lines 1100 1100
=======================================
Hits 1085 1085
Misses 10 10
Partials 5 5 Continue to review full report at Codecov.
|
abhinav
approved these changes
Feb 22, 2022
Comment on lines
+253
to
+259
| fx.Module("child", | ||
| fx.Decorate(func() *Config { | ||
| return &Config{Scope: "child"} | ||
| }), | ||
| fx.Invoke(func(l *Logger) { | ||
| assert.Equal(t, "child logger", l.Cfg.Scope) | ||
| }), |
There was a problem hiding this comment.
😮
I didn't think of this one. This is nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds more cases of fx.Decorate tests, specifically for
transitive dependencies that are decorated. For example, when a
function depends on type A whose constructor depends on type B,
and B has a decorator associated with it, we expect type A's constructor
to use the decorated value of B in its constructor.