Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Typo for ConsoleLogger godoc #842

Merged
merged 1 commit into from Feb 17, 2022
Merged

Fix Typo for ConsoleLogger godoc #842

merged 1 commit into from Feb 17, 2022

Conversation

GalvinGao
Copy link
Contributor

@GalvinGao GalvinGao commented Feb 17, 2022 •
edited

lol just spotted when reading the godoc :D

@CLAassistant
Copy link

CLAassistant commented Feb 17, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@sywhang
Copy link
Contributor

sywhang commented Feb 17, 2022

Thanks, could you please sign the CLA?

@GalvinGao
Copy link
Contributor Author

Thanks, could you please sign the CLA?

Just did :D

@sywhang sywhang merged commit 66a9373 into uber-go:master Feb 17, 2022
@GalvinGao GalvinGao deleted the patch-1 branch February 17, 2022 14:52
@GalvinGao
Copy link
Contributor Author

Thanks for the speedy review! That's one of the fastest merge along PRs I ever created :D

@sywhang
Copy link
Contributor

sywhang commented Feb 17, 2022

😄 thank you for your contribution!

josephinedotlee pushed a commit that referenced this pull request Feb 18, 2022
@GalvinGao @josephinedotlee
Fix Typo for ConsoleLogger godoc (#842)
947a003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sywhang sywhang sywhang approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GalvinGao @CLAassistant @sywhang