Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go 1.19 / Remove deprecated API usage #352

Merged
merged 3 commits into from
Aug 3, 2022
Merged

Conversation

sywhang
Copy link
Contributor

@sywhang sywhang commented Aug 3, 2022

Go 1.19 is out. Let's use it in the CI.

Also, this updates staticcheck version and removes deprecated API usage.

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #352 (7d483c9) into master (7398ffb) will not change coverage.
The diff coverage is n/a.

❗ Current head 7d483c9 differs from pull request most recent head 8c133af. Consider uploading reports for the commit 8c133af to get more accurate results

@@           Coverage Diff           @@
##           master     #352   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files          21       21           
  Lines        1450     1450           
=======================================
  Hits         1426     1426           
  Misses         15       15           
  Partials        9        9           
Impacted Files Coverage Δ
decorate.go 100.00% <ø> (ø)
error.go 100.00% <ø> (ø)
inout.go 100.00% <ø> (ø)
internal/digtest/container.go 100.00% <ø> (ø)
internal/graph/graph.go 100.00% <ø> (ø)
param.go 97.37% <ø> (ø)
provide.go 100.00% <ø> (ø)
visualize.go 89.74% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Collaborator

@abhinav abhinav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably gotta run gofmt

@sywhang sywhang changed the title ci: Use and test Go 1.19 Use Go 1.19 / Remove deprecated API usage Aug 3, 2022
@sywhang sywhang merged commit 50965fd into uber-go:master Aug 3, 2022
@sywhang sywhang deleted the use-119 branch August 3, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants