Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing unit tests on i686 architecture (RISC-V): constant 18446744073709551615 overflows uintptr #164

Closed
Hellseher opened this issue Apr 14, 2024 · 5 comments

Comments

@Hellseher
Copy link

Hellseher commented Apr 14, 2024

Hi,

During package review requiring to update Kubo (IPfs) in Guix, I've faced with
an issue when I try to build github.com/uber/atomic@1.8.0 on i686-linux machine:

# go.uber.org/atomic [go.uber.org/atomic.test]
src/go.uber.org/atomic/uintptr_test.go:72:29: constant 18446744073709551615 overflows uintptr
FAIL    go.uber.org/atomic [build failed]
FAIL

To reproduce the issue:

guix time-machine --commit=42b4580f6bfcaab009a56e679bd6f3c408ef03c9 -- \
    build --system=i686-linux go-go-uber-org-atomic

Thanks,
Oleg

@JacobOaks
Copy link
Contributor

Hey Oleg, can you clarify which version you're running on?

That line number is meaningless on master, and unless I'm missing something atomic doesn't have a version 18.0. Thanks.

@prashantv
Copy link
Collaborator

This looks similar to #99 which was fixed in #100.

@Hellseher
Copy link
Author

@JacobOaks it's v1.8.0, I've updated the comment.

@JacobOaks
Copy link
Contributor

@Hellseher can you try to upgrade to v1.11.0 which includes the fix mentioned by @prashantv? Let us know if that doesn't resolve the issue.

@Hellseher
Copy link
Author

@JacobOaks I can confirm, updating atomic to the latest version (v1.11.0)
resolved the test failing issue on RISK-V.

Thanks for the suggestion, clossing as resolved.

Oleg.

github-actions bot pushed a commit to guix-ru/guix that referenced this issue May 5, 2024
The upstream suggested to update to the latest version to resolve
failing tests on RISK-V, see
<uber-go/atomic#164>.

* gnu/packages/golang-xyz.scm (go-go-uber-org-atomic): Update to 1.11.0.
[arguments]: <#:tests?>: Enable tests on all platforms.

Change-Id: I6df21cfaebb9e4d4a609e93f3fe4bfea2bff5e8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants