Add Pointer[T] #116
Merged
Add Pointer[T] #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 22 +2
Lines 215 231 +16
=========================================
+ Hits 215 231 +16
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
sywhang
reviewed
Aug 9, 2022
This is necessary to use generics.
Adds a Pointer[T] type that provide the same functionality as Go 1.19's `sync/atomic.Pointer[T]` in both, Go 1.18 and 1.19. In Go 1.19, this uses the standard library's implementation, and in 1.18 our own custom implementation based on UnsafePointer. Refs GO-1572 Resolves #115
sywhang
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Pointer[T] type that provide the same functionality as
Go 1.19's
sync/atomic.Pointer[T]in both, Go 1.18 and 1.19.In Go 1.19, this uses the standard library's implementation,
and in 1.18 our own custom implementation based on UnsafePointer.
For Go 1.17, even though it's now unsupported, this is a no-op.
Refs GO-1572
Resolves #115