Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsafe redirect errors from Rollbar #3419

Open
murny opened this issue Mar 19, 2024 · 0 comments
Open

Fix unsafe redirect errors from Rollbar #3419

murny opened this issue Mar 19, 2024 · 0 comments

Comments

@murny
Copy link
Collaborator

murny commented Mar 19, 2024

We are getting a few of these:

image

We are redirecting to a generic request.referer which in Rails 7 is now an error since we are redirecting to an external URL.

We should look into improving this logic. Either approvelist the possible URLs here or just allow this behavior via allow_other_host: true

Maybe look into redirect_back_or_to method which might simplify this logic as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant