Parameterize and flesh out test_caches
#199
Milestone
Comments
masklinn
changed the title
test_core, parameterize and flesh out test_cachestest_caches
masklinn
added a commit
to masklinn/uap-python
that referenced
this issue
Mar 28, 2024
Partial results are back-filled (new domains added) by re-setting them in the cache. With a sufficiently incorrect implementation, the cache can evict entries on that occasion even though it does not need to (because we're replacing an existing entry). Exactly that should have been fixed by ua-parser#204, but was not tested at the time. Fixes ua-parser#199
Open
masklinn
added a commit
to masklinn/uap-python
that referenced
this issue
Mar 30, 2024
Partial results are back-filled (new domains added) by re-setting them in the cache. With a sufficiently incorrect implementation, the cache can evict entries on that occasion even though it does not need to (because we're replacing an existing entry). Exactly that should have been fixed by ua-parser#204, but was not tested at the time. Fixes ua-parser#199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#197 removed the caches from
test_core, because they added several seconds per cache per run, for basically no value: unless the cache is completely broken, the yaml tests from uap-core only have singletons so the caches didn't do anything.What would be more useful is having
test_cachesdo a lot more interesting generic stuff (e.g. test cache hits within the cache's size to ensure caches don't overclear — or underclear for that matter) stuff like that.Notably missing tests:
The text was updated successfully, but these errors were encountered: