Define =~ method on Timezone identifier #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's useful to match against a timezones identifier using regex. e.g. this rails issue: rails/rails#35973 this commit introduces the =~ operator to the Timezone class so that clients can match against its identifier by suppliying a regex.
itsWill
force-pushed
the
define_match_operator_on_timezone
branch
from
81bf61f
to
be116b2
Compare
|
🤔 I can't get a lot of insight out of the build failure, it seems like it's struggling to resolve the |
|
Thank you for submitting this pull request. I've merged the change. The build failure was unrelated. It was caused by an error verifying the rubygems.org TLS certificate. I've committed 719204b as a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to match agains a timezones identifier using regex.
e.g. this rails issue: rails/rails#35973 this
commit overrides the =~ operator to the Timezone class so that clients
can match against its identifier.