Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore SECURITY file when scanning timezones #134

Closed
Rdx31 opened this issue Jul 11, 2022 · 0 comments · Fixed by #133
Closed

Ignore SECURITY file when scanning timezones #134

Rdx31 opened this issue Jul 11, 2022 · 0 comments · Fixed by #133

Comments

@Rdx31
Copy link

Rdx31 commented Jul 11, 2022

Problem:

The Arch Linux core package tzdata adds a SECURITY file in /usr/share/tzinfo since tzdata version 2021c-1.

This file is basically a note to report security-related bugs to the right person:

Please report any sensitive security-related bugs via email to the
tzdb designated coordinators, currently Paul Eggert
<eggert@cs.ucla.edu> and Tim Parenti <tim@timtimeonline.com>.
Put "tzdb security" at the start of your email's subject line.
We prefer communications to be in English.

[...]

tzinfo wants to use this file, which leads to an error.

How to reproduce:

Using Ruby IRB:

>> require 'tzinfo'
=> true
>> TZInfo::Timezone.all.find_all {|tz| tz.current_period.abbreviation == :some_abbrev }
TZInfo::InvalidTimezoneIdentifier (The file '/usr/share/zoneinfo/SECURITY' does not start with the expected header. (loading SECURITY))

Information:

tool version
ruby 2.6.2p47
tzinfo 2.0.4
tzdata 2021c-1 and above
linux kernel 5.18.10-arch1-1

Fix:

I propose this PR to exclude the SECURITY file from beeing used by tzinfo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant