Skip to content

Minimum git version not checked #844

@therealgilles

Description

@therealgilles

Husky v5 does not check that git is at least 2.9. I was trying to install it with 2.8.1, nothing got installed but no errors were reported. It even tried to git commit my staged files.

Activity

typicode

typicode commented on Jan 26, 2021

@typicode
Owner

Thanks for the feedback. Out of curiosity what's the OS used, is it the default version?

therealgilles

therealgilles commented on Jan 26, 2021

@therealgilles
Author

I'm running Mac OS Big Sur 11.2 beta but I'm not sure Apple ships git with it.
It's possible I had not run brew update in a while, or that I had not run 'brew link --overwrite git' and /usr/local/bin/git was still pointing to the 2.8.1 version. Having a package install run 'git commit' without an explanation is very disconcerting.

typicode

typicode commented on Jan 26, 2021

@typicode
Owner

Ok, I think I better understand the issue. I'll fix that 👍

typicode

typicode commented on Jan 28, 2021

@typicode
Owner

Should be good in v5.0.8

therealgilles

therealgilles commented on Jan 28, 2021

@therealgilles
Author

Could be useful to mention in a comment to check the git version maybe?

typicode

typicode commented on Jan 28, 2021

@typicode
Owner

Agree, I'll add that to the docs.

typicode

typicode commented on Jan 28, 2021

@typicode
Owner

I've updated the troubleshoot section with Git version requirement 👍

83 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Minimum git version not checked · Issue #844 · typicode/husky