Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum git version not checked #844

Comments

@therealgilles
Copy link

Husky v5 does not check that git is at least 2.9. I was trying to install it with 2.8.1, nothing got installed but no errors were reported. It even tried to git commit my staged files.

@typicode
Copy link
Owner

Thanks for the feedback. Out of curiosity what's the OS used, is it the default version?

@therealgilles
Copy link
Author

therealgilles commented Jan 26, 2021

I'm running Mac OS Big Sur 11.2 beta but I'm not sure Apple ships git with it.
It's possible I had not run brew update in a while, or that I had not run 'brew link --overwrite git' and /usr/local/bin/git was still pointing to the 2.8.1 version. Having a package install run 'git commit' without an explanation is very disconcerting.

@typicode
Copy link
Owner

Ok, I think I better understand the issue. I'll fix that 👍

@typicode
Copy link
Owner

Should be good in v5.0.8

@therealgilles
Copy link
Author

Could be useful to mention in a comment to check the git version maybe?

@typicode
Copy link
Owner

Agree, I'll add that to the docs.

@typicode
Copy link
Owner

I've updated the troubleshoot section with Git version requirement 👍

This was referenced Mar 7, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment