Skip to content

Fix whitespace in project folder name issue #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 13, 2018
Merged

Fix whitespace in project folder name issue #423

merged 7 commits into from
Dec 13, 2018

Conversation

klmdb
Copy link
Contributor

@klmdb klmdb commented Dec 13, 2018

No description provided.

@typicode
Copy link
Owner

Thanks for the PR 👍

Hmm don't really know why it fails with snapshots, they seem good in the PR.

Usually, you can leave the package version as it is. This way project authors can bump the version just when needed.

@typicode
Copy link
Owner

Can you try running npm test -- -u or npx jest -u to update snapshots, it should fix the failing CI.

typicode and others added 2 commits December 13, 2018 12:59

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-Authored-By: klmdb <klmdb@users.noreply.github.com>
@klmdb
Copy link
Contributor Author

klmdb commented Dec 13, 2018

npm test -- -u did the trick

@typicode
Copy link
Owner

Thanks :)

@typicode typicode merged commit aabd390 into typicode:master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants