Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install or first-use instructions in readme.md fail #1169

Closed
abelbraaksma opened this issue Jul 6, 2022 · 7 comments
Closed

Install or first-use instructions in readme.md fail #1169

abelbraaksma opened this issue Jul 6, 2022 · 7 comments

Comments

@abelbraaksma
Copy link

abelbraaksma commented Jul 6, 2022

The readme.md for Husky has this line to be executed after you install Husky:

npm set-script prepare "husky install"

This npm command doesn't exist and just shows the npm help screen.

I found an alternative command in some PR here (#1154), which appears to be merged but doesn't show up in the readme.md, however, it fails just the same:

npm pkg set scripts.prepare="husky install"

And trying to run the npm run prepare command regardless leads to a bunch of errors, likely because the original commands don't work:

npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path d:\Projects\Lula\billing\package.json
npm ERR! errno -4058
npm ERR! enoent ENOENT: no such file or directory, open 'd:\Projects\Lula\billing\package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

This is on Windows 10 with .NET 6 and npm 6.14.8, if it matters. I've no idea how to install Husky though I'd love to try it out. Anybody know how to install it properly and/or edit the readme.md to contain instructions that work?

@abelbraaksma
Copy link
Author

abelbraaksma commented Jul 6, 2022

Ok, I just realized that my npm wasn't up-to-date, I first had to run:

npm install -g npm

While the command from the main readme.md still isn't working (it now gives a deprecation warning), the one from the PR #1154 now is and I can continue.

And now, npm run prepare actually works.

@coolaj86
Copy link

Bump.

GitHub failed to re-render the README.md what's showing is out-of-sync from what's committed to the repo.

@abelbraaksma
Copy link
Author

@coolaj86 that's weird!

@stale
Copy link

stale bot commented Sep 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 19, 2022
@abelbraaksma
Copy link
Author

The bot shouldn’t close this. @coolaj86, the readme still shows old instructions.

@stale stale bot removed the wontfix label Sep 20, 2022
@stale
Copy link

stale bot commented Dec 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 19, 2022
@abelbraaksma
Copy link
Author

@coolaj86 meanwhile the change is visible. Not sure what’s changed since last time. Will close as fixed (I can’t change the label, but really, it is fixed!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants