Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Guava version 33.1.0 #6546

Merged
merged 8 commits into from Apr 28, 2024
Merged

Use Guava version 33.1.0 #6546

merged 8 commits into from Apr 28, 2024

Conversation

mernst
Copy link
Member

@mernst mernst commented Apr 24, 2024

No description provided.

@mernst mernst linked an issue Apr 24, 2024 that may be closed by this pull request
build.gradle Outdated
// javax.annotation.meta.TypeQualifierDefault not found". I was not able to
// figure out how to use Gradle's exclusions (of transitive dependencies) in
// order to avoid the need for this.
annotatedGuava 'com.google.code.findbugs:jsr305:3.0.2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is needed because the pom file in Maven central doesn't have Guava's dependencies. See: https://central.sonatype.com/artifact/org.checkerframework.annotatedlib/guava/dependencies

Compared to Google's version:
https://central.sonatype.com/artifact/com.google.guava/guava/dependencies

You'll need to release annotated Guava to fix this. (I'm also ok if you want to merge this work around.)

@smillst smillst assigned mernst and unassigned smillst Apr 26, 2024
@mernst mernst merged commit 81f7d01 into typetools:master Apr 28, 2024
28 checks passed
@mernst mernst deleted the update-guava branch April 28, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update org.checkerframework.annotatedlib:guava to Guava 33.1.0
2 participants