Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PolymorphicQualifier for qualifiers with elements (values, fields) #58

Closed
GoogleCodeExporter opened this issue Jul 3, 2015 · 6 comments
Milestone

Comments

@GoogleCodeExporter
Copy link

Currently, checkers.quals.PolymorphicQualifier does not support an
annotation value.

In contrast, checkers.igj.quals.I supports a String to distinguish
different uses of the polymorphic qualifier.

Adding a String value to PolymorphicQualifier would give the same
expressiveness to the type systems using it, e.g. PolyNull.

Original issue reported on code.google.com by wdi...@gmail.com on 16 Feb 2010 at 1:43

@GoogleCodeExporter
Copy link
Author

This is a generalization of issue 54.  (And is the right way to solve issue 54.)

Original comment by michael.ernst@gmail.com on 16 Feb 2010 at 3:38

  • Added labels: Priority-Medium
  • Removed labels: Priority-Low

@GoogleCodeExporter
Copy link
Author

Can you explain the proposal again please?  PolymorphicQualifier is 
meta-annotation on the annotation 
declaration, so programmers shouldn't use it directly.

Providing an example of how it might work in practice would help our 
understanding.

Original comment by notn...@gmail.com on 26 Feb 2010 at 10:33

@GoogleCodeExporter
Copy link
Author

@PolymorphicQualifier should not take an argument.  (So the text about "Adding a
String value to PolymorphicQualifier" in the original request is a bit 
misleading .)

Rather, the proposal is that every qualifier marked as @PolymorphicQualifier 
should
take an optional argument, and the Checker Framework should respect the argument
while doing checking.

After this enhancement, then it would be possible to meta-annotate @I as
@PolymorphicQualifier.  All handling for the argument to @I could be moved out 
of the
IGJ checker and into the framework proper, where other checkers could take 
advantage
if it for free.

Original comment by michael.ernst@gmail.com on 27 Feb 2010 at 12:10

@GoogleCodeExporter
Copy link
Author

Issue 54 has been merged into this issue.

Original comment by notn...@gmail.com on 3 Mar 2010 at 10:37

@GoogleCodeExporter
Copy link
Author

Original comment by michael.ernst@gmail.com on 26 Jan 2011 at 9:52

  • Added labels: Priority-Low
  • Removed labels: Priority-Medium

@mernst mernst modified the milestone: Low Jul 10, 2015
smillst pushed a commit to smillst/checker-framework that referenced this issue May 24, 2019
@mernst mernst changed the title PolymorphicQualifier with values PolymorphicQualifier for qualifiers with elements (values, fields) May 9, 2022
@mernst
Copy link
Member

mernst commented May 9, 2022

This issue was fixed quite a while ago.

@mernst mernst closed this as completed May 9, 2022
mernst added a commit that referenced this issue May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants