Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createAnnotationForStringConcatenation() has copy and paste and edit code; needs refactoring #4855

Closed
smonteiro opened this issue Aug 2, 2021 · 3 comments
Closed

createAnnotationForStringConcatenation() has copy and paste and edit code; needs refactoring #4855

smonteiro opened this issue Aug 2, 2021 · 3 comments

Comments

@smonteiro
Copy link
Contributor

Thanks for submitting an issue.
As explained in the instructions for submitting an issue at https://checkerframework.org/manual/#reporting-bugs, please include four pieces of information:

  • commands (that can be cut-and-pasted into a command shell),
  • inputs,
  • outputs, and
  • expectation.
@smonteiro
Copy link
Contributor Author

I have a local refactored version of it that I intend to commit.
My development environment is out of date so this may take a few days.

smonteiro added a commit to smonteiro/checker-framework that referenced this issue Aug 2, 2021
@smonteiro
typetools#4855 refactored body of function CreateAnnotationForStringC…
a72027c 
…oncatenation
smonteiro added a commit to smonteiro/checker-framework that referenced this issue Aug 3, 2021
@smonteiro
typetools#4855 moved convenience functions to end of file
d7e026c
@smonteiro
Copy link
Contributor Author

pull request submitted

smonteiro added a commit to smonteiro/checker-framework that referenced this issue Aug 4, 2021
@smonteiro
typetools#4855 better method name appendNullToLengthRange
f29ece6
smonteiro added a commit to smonteiro/checker-framework that referenced this issue Aug 4, 2021
@smonteiro
typetools#4855 appendNullToLengths is better name
fd58c7b
@mernst
Copy link
Member

mernst commented Aug 5, 2021

I'm re-opening this issue because it is not resolved until the pull request #4857 is merged. When that pull request is merged, this issue will be automatically closed. I did that via "Linked issues" on that pull request page.

@mernst mernst reopened this Aug 5, 2021
@mernst mernst linked a pull request Aug 5, 2021 that will close this issue
Issue4855 attempt to refactor CreateAnnotationForStringConcatenation() #4857
Closed
@mernst mernst closed this as completed Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue4855 attempt to refactor CreateAnnotationForStringConcatenation() smonteiro/checker-framework
2 participants
@mernst @smonteiro