Validate return types correctly. #4844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mernst
approved these changes
Jul 28, 2021
| @@ -471,6 +472,14 @@ protected void visitTypeParameterBounds( | |||
| case TYPE_PARAMETER: | |||
There was a problem hiding this comment.
The Javadoc for the containing method twice says "type parameter tree" and once says "parameter type tree". Please make them consistent.
wmdietl
pushed a commit
to eisop/checker-framework
that referenced
this pull request
Aug 3, 2021
wmdietl
pushed a commit
to eisop/checker-framework
that referenced
this pull request
Aug 3, 2021
cpovirk
added a commit
to jspecify/jspecify
that referenced
this pull request
Dec 28, 2021
…its. I suspect that our prototype checker's behavior for such mismatches is fixed by typetools/checker-framework#4844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.