Inability to write annotations on the outer class portion of an inner class name

[jwaataja]

Dataflow seems to break with inner class types.

import org.checkerframework.checker.tainting.qual.*;

public class C {
    void method(@Tainted Inner param) {
        @Tainted C. @Untainted Inner local = param;
    }

    class Inner {
    }
}

I get this error,

C.java:5: error: [type.invalid.conflicting.annos] invalid type: conflicting annotations [@Tainted, @Untainted] in type "@Tainted C.@Tainted @Untainted Inner"
        @Tainted C. @Untainted Inner local = param;
                                     ^

I would expect to instead get an invalid assignment error. It seems dataflow tries to replace the inner type but doesn't remove the old annotation.

[jwaataja]

I originally thought this had something to do with dataflow, but it didn't. Simplified test case:

import org.checkerframework.checker.tainting.qual.*;

public class C {
    @Tainted C. @Untainted Inner field;

    class Inner {
    }
}

The JLS specifies that on fields, the annotation immediately before the type is a modifier of the field itself, so it makes sense that both annotations are written on the Inner class. However, this raises the question of how to specify the type @Tainted C. @Untainted Inner. That is, an @Untainted instance of Inner where C.this has type @Tainted. There's no way to write the annotation on C specifically, both annotations apply to the inner class.

[smillst]

I've confirmed this is a bug in they way the Checker Framework decodes annotations from VariableTrees. I'm working on fixing it.