Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Ainfer causes crash with multi-dimensional arrays #3422

Closed
jwaataja opened this issue Jul 3, 2020 · 0 comments · Fixed by #3435
Closed

-Ainfer causes crash with multi-dimensional arrays #3422

jwaataja opened this issue Jul 3, 2020 · 0 comments · Fixed by #3435
Assignees
@kelloggm

Comments

@jwaataja
Copy link
Contributor

jwaataja commented Jul 3, 2020

When I use the -Ainfer option on the following code, I code a crash. It seems to happen with two-dimensional arrays.

public class C {
    boolean[][] field = null;
}
$CHECKERFRAMEWORK/checker/bin/javac -processor org.checkerframework.checker.nullness.NullnessChecker -Ainfer=stubs C.java
error: SourceChecker.typeProcess: unexpected Throwable (NullPointerException) while processing C.java
  ; The Checker Framework crashed.  Please report the crash.
  Compilation unit: C.java
  Last visited tree at line 2 column 25:
      boolean[][] field = null;
  Exception: java.lang.NullPointerException; java.lang.NullPointerException
  	at org.checkerframework.common.wholeprograminference.SceneToStubWriter.formatArrayTypeImpl(SceneToStubWriter.java:244)
  	at org.checkerframework.common.wholeprograminference.SceneToStubWriter.formatArrayType(SceneToStubWriter.java:179)
  	at org.checkerframework.common.wholeprograminference.SceneToStubWriter.formatType(SceneToStubWriter.java:384)
  	at org.checkerframework.common.wholeprograminference.SceneToStubWriter.formatType(SceneToStubWriter.java:347)
  	at org.checkerframework.common.wholeprograminference.SceneToStubWriter.formatAFieldImpl(SceneToStubWriter.java:315)
  	at org.checkerframework.common.wholeprograminference.SceneToStubWriter.printField(SceneToStubWriter.java:514)
  	at org.checkerframework.common.wholeprograminference.SceneToStubWriter.printFields(SceneToStubWriter.java:493)
  	at org.checkerframework.common.wholeprograminference.SceneToStubWriter.printClass(SceneToStubWriter.java:693)
  	at org.checkerframework.common.wholeprograminference.SceneToStubWriter.writeImpl(SceneToStubWriter.java:616)
  	at org.checkerframework.common.wholeprograminference.SceneToStubWriter.write(SceneToStubWriter.java:89)
  	at org.checkerframework.common.wholeprograminference.scenelib.ASceneWrapper.writeToFile(ASceneWrapper.java:146)
  	at org.checkerframework.common.wholeprograminference.WholeProgramInferenceScenesStorage.writeScenes(WholeProgramInferenceScenesStorage.java:110)
  	at org.checkerframework.common.wholeprograminference.WholeProgramInferenceScenes.writeResultsToFile(WholeProgramInferenceScenes.java:423)
  	at org.checkerframework.framework.type.AnnotatedTypeFactory.postProcessClassTree(AnnotatedTypeFactory.java:1121)
  	at org.checkerframework.common.basetype.BaseTypeVisitor.visitClass(BaseTypeVisitor.java:327)
  	at org.checkerframework.common.basetype.BaseTypeVisitor.visitClass(BaseTypeVisitor.java:165)
  	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:808)
  	at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:56)
  	at org.checkerframework.framework.source.SourceVisitor.visit(SourceVisitor.java:82)
  	at org.checkerframework.framework.source.SourceChecker.typeProcess(SourceChecker.java:894)
  	at org.checkerframework.common.basetype.BaseTypeChecker.typeProcess(BaseTypeChecker.java:510)
  	at org.checkerframework.javacutil.AbstractTypeProcessor$AttributionTaskListener.finished(AbstractTypeProcessor.java:190)
  	at jdk.compiler/com.sun.tools.javac.api.ClientCodeWrapper$WrappedTaskListener.finished(ClientCodeWrapper.java:828)
  	at jdk.compiler/com.sun.tools.javac.api.MultiTaskListener.finished(MultiTaskListener.java:132)
  	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1418)
  	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1375)
  	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:973)
  	at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:311)
  	at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:170)
  	at jdk.compiler/com.sun.tools.javac.Main.compile(Main.java:57)
  	at jdk.compiler/com.sun.tools.javac.Main.main(Main.java:43)
C.java:2: error: [assignment.type.incompatible] incompatible types in assignment.
    boolean[][] field = null;
                        ^
  found   : null
  required: @Initialized @NonNull boolean @Initialized @NonNull [] @Initialized @NonNull []
2 errors

When I use bin-devel/javac, I get a different crash.

$CHECKERFRAMEWORK/checker/bin-devel/javac -processor org.checkerframework.checker.nullness.NullnessChecker -Ainfer=stubs C.java
error: SourceChecker.typeProcess: unexpected Throwable (NoSuchMethodError) while processing C.java; message: 'void scenelib.annotations.el.AClass.setTypeElement(javax.lang.model.element.TypeElement)'
  ; The Checker Framework crashed.  Please report the crash.
  Compilation unit: C.java
  Last visited tree at line 1 column 1:
  public class C {
  Exception: java.lang.NoSuchMethodError: 'void scenelib.annotations.el.AClass.setTypeElement(javax.lang.model.element.TypeElement)'; java.lang.NoSuchMethodError: 'void scenelib.annotations.el.AClass.setTypeElement(javax.lang.model.element.TypeElement)'
  	at org.checkerframework.common.wholeprograminference.scenelib.ASceneWrapper.updateSymbolInformation(ASceneWrapper.java:219)
  	at org.checkerframework.common.wholeprograminference.WholeProgramInferenceScenesStorage.getAClass(WholeProgramInferenceScenesStorage.java:170)
  	at org.checkerframework.common.wholeprograminference.WholeProgramInferenceScenes.updateFromFieldAssignment(WholeProgramInferenceScenes.java:302)
  	at org.checkerframework.framework.flow.CFAbstractTransfer.visitAssignment(CFAbstractTransfer.java:814)
  	at org.checkerframework.framework.flow.CFAbstractTransfer.visitAssignment(CFAbstractTransfer.java:91)
  	at org.checkerframework.dataflow.cfg.node.AssignmentNode.accept(AssignmentNode.java:62)
  	at org.checkerframework.dataflow.analysis.Analysis.callTransferFunction(Analysis.java:437)
  	at org.checkerframework.dataflow.analysis.Analysis.performAnalysisBlock(Analysis.java:226)
  	at org.checkerframework.dataflow.analysis.Analysis.performAnalysis(Analysis.java:201)
  	at org.checkerframework.framework.flow.CFAbstractAnalysis.performAnalysis(CFAbstractAnalysis.java:109)
  	at org.checkerframework.framework.type.GenericAnnotatedTypeFactory.analyze(GenericAnnotatedTypeFactory.java:1243)
  	at org.checkerframework.framework.type.GenericAnnotatedTypeFactory.performFlowAnalysis(GenericAnnotatedTypeFactory.java:1111)
  	at org.checkerframework.framework.type.GenericAnnotatedTypeFactory.checkAndPerformFlowAnalysis(GenericAnnotatedTypeFactory.java:1527)
  	at org.checkerframework.framework.type.GenericAnnotatedTypeFactory.preProcessClassTree(GenericAnnotatedTypeFactory.java:258)
  	at org.checkerframework.common.basetype.BaseTypeVisitor.visitClass(BaseTypeVisitor.java:307)
  	at org.checkerframework.common.basetype.BaseTypeVisitor.visitClass(BaseTypeVisitor.java:165)
  	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:808)
  	at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:56)
  	at org.checkerframework.framework.source.SourceVisitor.visit(SourceVisitor.java:82)
  	at org.checkerframework.framework.source.SourceChecker.typeProcess(SourceChecker.java:894)
  	at org.checkerframework.common.basetype.BaseTypeChecker.typeProcess(BaseTypeChecker.java:510)
  	at org.checkerframework.common.basetype.BaseTypeChecker.typeProcess(BaseTypeChecker.java:503)
  	at org.checkerframework.javacutil.AbstractTypeProcessor$AttributionTaskListener.finished(AbstractTypeProcessor.java:190)
  	at jdk.compiler/com.sun.tools.javac.api.ClientCodeWrapper$WrappedTaskListener.finished(ClientCodeWrapper.java:828)
  	at jdk.compiler/com.sun.tools.javac.api.MultiTaskListener.finished(MultiTaskListener.java:132)
  	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1418)
  	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1375)
  	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:973)
  	at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:311)
  	at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:170)
  	at jdk.compiler/com.sun.tools.javac.Main.compile(Main.java:57)
  	at jdk.compiler/com.sun.tools.javac.Main.main(Main.java:43)
error: SourceChecker.typeProcess: unexpected Throwable (NoSuchMethodError) while processing C.java; message: 'void scenelib.annotations.el.AClass.setTypeElement(javax.lang.model.element.TypeElement)'
  ; The Checker Framework crashed.  Please report the crash.
  Compilation unit: C.java
  Last visited tree at line 1 column 1:
  public class C {
  Exception: java.lang.NoSuchMethodError: 'void scenelib.annotations.el.AClass.setTypeElement(javax.lang.model.element.TypeElement)'; java.lang.NoSuchMethodError: 'void scenelib.annotations.el.AClass.setTypeElement(javax.lang.model.element.TypeElement)'
  	at org.checkerframework.common.wholeprograminference.scenelib.ASceneWrapper.updateSymbolInformation(ASceneWrapper.java:219)
  	at org.checkerframework.common.wholeprograminference.WholeProgramInferenceScenesStorage.getAClass(WholeProgramInferenceScenesStorage.java:170)
  	at org.checkerframework.common.wholeprograminference.WholeProgramInferenceScenes.updateFromFieldAssignment(WholeProgramInferenceScenes.java:302)
  	at org.checkerframework.framework.flow.CFAbstractTransfer.visitAssignment(CFAbstractTransfer.java:814)
  	at org.checkerframework.checker.initialization.InitializationTransfer.visitAssignment(InitializationTransfer.java:149)
  	at org.checkerframework.checker.initialization.InitializationTransfer.visitAssignment(InitializationTransfer.java:57)
  	at org.checkerframework.dataflow.cfg.node.AssignmentNode.accept(AssignmentNode.java:62)
  	at org.checkerframework.dataflow.analysis.Analysis.callTransferFunction(Analysis.java:437)
  	at org.checkerframework.dataflow.analysis.Analysis.performAnalysisBlock(Analysis.java:226)
  	at org.checkerframework.dataflow.analysis.Analysis.performAnalysis(Analysis.java:201)
  	at org.checkerframework.framework.flow.CFAbstractAnalysis.performAnalysis(CFAbstractAnalysis.java:109)
  	at org.checkerframework.framework.type.GenericAnnotatedTypeFactory.analyze(GenericAnnotatedTypeFactory.java:1243)
  	at org.checkerframework.framework.type.GenericAnnotatedTypeFactory.performFlowAnalysis(GenericAnnotatedTypeFactory.java:1111)
  	at org.checkerframework.framework.type.GenericAnnotatedTypeFactory.checkAndPerformFlowAnalysis(GenericAnnotatedTypeFactory.java:1527)
  	at org.checkerframework.framework.type.GenericAnnotatedTypeFactory.preProcessClassTree(GenericAnnotatedTypeFactory.java:258)
  	at org.checkerframework.common.basetype.BaseTypeVisitor.visitClass(BaseTypeVisitor.java:307)
  	at org.checkerframework.common.basetype.BaseTypeVisitor.visitClass(BaseTypeVisitor.java:165)
  	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:808)
  	at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:56)
  	at org.checkerframework.framework.source.SourceVisitor.visit(SourceVisitor.java:82)
  	at org.checkerframework.framework.source.SourceChecker.typeProcess(SourceChecker.java:894)
  	at org.checkerframework.common.basetype.BaseTypeChecker.typeProcess(BaseTypeChecker.java:510)
  	at org.checkerframework.javacutil.AbstractTypeProcessor$AttributionTaskListener.finished(AbstractTypeProcessor.java:190)
  	at jdk.compiler/com.sun.tools.javac.api.ClientCodeWrapper$WrappedTaskListener.finished(ClientCodeWrapper.java:828)
  	at jdk.compiler/com.sun.tools.javac.api.MultiTaskListener.finished(MultiTaskListener.java:132)
  	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1418)
  	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1375)
  	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:973)
  	at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:311)
  	at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:170)
  	at jdk.compiler/com.sun.tools.javac.Main.compile(Main.java:57)
  	at jdk.compiler/com.sun.tools.javac.Main.main(Main.java:43)
2 errors

Here's the output for

$CHECKERFRAMEWORK/checker/bin/javac -processor org.checkerframework.checker.nullness.NullnessChecker -Ainfer=stubs C.java -version -verbose -AprintAllQualifiers

and

$CHECKERFRAMEWORK/checker/bin-devel/javac -processor org.checkerframework.checker.nullness.NullnessChecker -Ainfer=stubs C.java -version -verbose -AprintAllQualifiers

bin-javac-output.txt
bin-devel-javac-output.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kelloggm kelloggm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix null-pointer crash in Ainfer=stubs kelloggm/checker-framework
2 participants
@kelloggm @jwaataja