Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constant Value Checker: avoid using areSameByClass. #2987

Merged
merged 17 commits into from Jan 2, 2020

Conversation

smillst
Copy link
Member

@smillst smillst commented Dec 16, 2019

Use areSameByName(AnnotationMirror, String) instead of areSameByClass. These changes only speed up the checker by ~5%. However, if/when we remove the static cache in areSameByClass, then these changes are needed so that the checker isn't any slower.

@mernst
Copy link
Member

mernst commented Dec 17, 2019

@smillst The misc CI failures are:

framework/src/main/java/org/checkerframework/common/value/ValueAnnotatedTypeFactory.java:1046: warning: no @param for anno
framework/src/main/java/org/checkerframework/common/value/ValueAnnotatedTypeFactory.java:1046: warning: no @return
framework/src/main/java/org/checkerframework/common/value/ValueAnnotatedTypeFactory.java:1086: warning: no @param for anm
framework/src/main/java/org/checkerframework/common/value/ValueAnnotatedTypeFactory.java:1105: warning: no @param for anno
framework/src/main/java/org/checkerframework/common/value/ValueAnnotatedTypeFactory.java:1105: warning: no @return
framework/src/main/java/org/checkerframework/common/value/ValueAnnotatedTypeFactory.java:1591: warning: no @param for receiverType
framework/src/main/java/org/checkerframework/common/value/ValueAnnotatedTypeFactory.java:1591: warning: no @return
framework/src/main/java/org/checkerframework/common/value/ValueAnnotatedTypeFactory.java:2290: warning: no @param for atm
framework/src/main/java/org/checkerframework/common/value/ValueAnnotatedTypeFactory.java:2290: warning: no @return
framework/src/main/java/org/checkerframework/common/value/ValueTransfer.java:104: warning: no @param for subNode
framework/src/main/java/org/checkerframework/common/value/ValueTransfer.java:104: warning: no @param for p
framework/src/main/java/org/checkerframework/common/value/ValueTransfer.java:104: warning: no @return
framework/src/main/java/org/checkerframework/common/value/ValueTransfer.java:185: warning: no @param for subNode
framework/src/main/java/org/checkerframework/common/value/ValueTransfer.java:185: warning: no @param for p
framework/src/main/java/org/checkerframework/common/value/ValueTransfer.java:185: warning: no @return
framework/src/main/java/org/checkerframework/common/value/ValueTransfer.java:343: warning: no @param for node
framework/src/main/java/org/checkerframework/common/value/ValueTransfer.java:343: warning: no @param for anno
framework/src/main/java/org/checkerframework/common/value/ValueTransfer.java:343: warning: no @return

@smillst smillst assigned wmdietl and unassigned smillst Dec 17, 2019
# Conflicts:
#	framework/src/main/java/org/checkerframework/common/value/ValueAnnotatedTypeFactory.java
@smillst smillst merged commit ac23946 into typetools:master Jan 2, 2020
@smillst smillst deleted the valueQualifierHierarchy branch January 2, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants