Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mistake in making error message #48

Open
qodunpob opened this issue Feb 23, 2021 · 1 comment
Open

Mistake in making error message #48

qodunpob opened this issue Feb 23, 2021 · 1 comment
Labels
type: fix Issues describing a broken feature.

Comments

@qodunpob
Copy link

There is a mistake:
https://github.com/typeorm/typeorm-typedi-extensions/blob/b6d540e2084c832a66573b23374384d367f725f5/src/errors/entity-type-missing.error.ts#L6

The addition operation will be executed first and the result will never be undefined. For the same reason Missing "entityType" parameter of "@InjectRepository" decorator will never be printed.
@NoNameProvided NoNameProvided added the type: fix Issues describing a broken feature. label Mar 23, 2021
@NoNameProvided
Copy link
Member

Care to make a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: fix Issues describing a broken feature.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qodunpob @NoNameProvided