Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question: isPhoneNumber validation input without country code #2406

Open
antoineheseque opened this issue Feb 5, 2024 · 1 comment
Open
Labels
type: question Questions about the usage of the library.

Comments

@antoineheseque
Copy link

antoineheseque commented Feb 5, 2024

In version 0.14.0 telephone numbers starting with french code +337 (e.g. +33701020304 ) worked. Since version 0.14.1, this no longer works, even when specifying country code.

It looks like this issue has already been identified, see https://gitlab.com/catamphetamine/libphonenumber-js/-/issues/133

I'm gonna downgrade class-validator to version 0.14.0 while libphonenumber library patches this problem.
Should I leave this issue here or close it ?
(I changed my comment following my research about this issue, the title might not be in line with this new comment)

@antoineheseque antoineheseque added the type: question Questions about the usage of the library. label Feb 5, 2024
@Benbb96
Copy link

Benbb96 commented Mar 26, 2024

Hi @antoineheseque, I've been mistaken as well before 😄

I believe numbers starting by +337 start to be valid at +3373... They are possible before (from +33700... to +33729...) but not valid for now.

Your example seems to be a test number and not real one so I don't think it's a bug from the libphonenumber dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: question Questions about the usage of the library.
Development

No branches or pull requests

2 participants