Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: options for @IsBase64 decorator are ignored #2374

Open
Clashsoft opened this issue Jan 12, 2024 · 1 comment · May be fixed by #2383
Open

fix: options for @IsBase64 decorator are ignored #2374

Clashsoft opened this issue Jan 12, 2024 · 1 comment · May be fixed by #2383
Labels
status: needs triage Issues which needs to be reproduced to be verified report. type: fix Issues describing a broken feature.

Comments

@Clashsoft
Copy link
Contributor

Clashsoft commented Jan 12, 2024 •
edited

Description

See https://github.com/typestack/class-validator/pull/1845/files#diff-020eb68c18b00e6111d4f45ca7c83b4d43646ac381ab4a646308fa7789e46812L24

The options argument is never passed to the isBase64 function.

Expected behavior

The options argument is not ignored.

Actual behavior

The options argument is ignored.

Related

PR #1845
@Clashsoft Clashsoft added status: needs triage Issues which needs to be reproduced to be verified report. type: fix Issues describing a broken feature. labels Jan 12, 2024
@Clashsoft
Copy link
Contributor Author

In addition, that PR was a breaking change. @NoNameProvided

@alenap93 alenap93 linked a pull request Jan 16, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: needs triage Issues which needs to be reproduced to be verified report. type: fix Issues describing a broken feature.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: set options from decorator to IsBase64 method alenap93/class-validator
1 participant
@Clashsoft