Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update project tooling #376

Merged
merged 12 commits into from Jul 29, 2020
Merged

Conversation

NoNameProvided
Copy link
Member

This PR:

  • updates .gitignore file to exclude common OS generated files
  • updates the year in the license
  • configures TS and Jest with more modern settings
  • adds Prettier (formatting has not been done as it would cause conflict with every PR)
  • adds Husky and lint-staged for auto-formatting during commits (new code additions become well formatted)
  • updates CI configs to
    • run lint, format, test, build in different tasks for faster feedback
    • removes Travis in favor of GH Actions
    • adds support for auto-deploying GH releases

In a separate PR I also need to add some documentation about:

  • how make a release
  • commit and PR naming schemes
  • some other possible tooling information

package.json Outdated Show resolved Hide resolved
@@ -0,0 +1,8 @@
printWidth: 120
tabWidth: 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setting will create a big diff on the next PR, because most of the tabulations on the code is defined as 4 spaces. Should we change it now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I know. I did not run prettier for this reason. We should clean up the PRs and only autoformat after.

.prettierrc.yml Outdated Show resolved Hide resolved
codecov.yml Outdated Show resolved Hide resolved
package-lock.json Show resolved Hide resolved
@saulotoledo
Copy link
Member

LGTM.

@NoNameProvided NoNameProvided merged commit 376e4d6 into develop Jul 29, 2020
@NoNameProvided NoNameProvided deleted the build/update-project-tooling branch July 29, 2020 16:21
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants