From ab9a7d81e19230e722563392e94fc97ea3fd176c Mon Sep 17 00:00:00 2001 From: danny-may Date: Wed, 10 Nov 2021 17:04:02 +0000 Subject: [PATCH] feat(eslint-plugin): add escape condition for private fields --- .../eslint-plugin/src/rules/explicit-member-accessibility.ts | 4 ++++ .../tests/rules/explicit-member-accessibility.test.ts | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/eslint-plugin/src/rules/explicit-member-accessibility.ts b/packages/eslint-plugin/src/rules/explicit-member-accessibility.ts index dc549fc1411..8a8446ec0af 100644 --- a/packages/eslint-plugin/src/rules/explicit-member-accessibility.ts +++ b/packages/eslint-plugin/src/rules/explicit-member-accessibility.ts @@ -214,6 +214,10 @@ export default util.createRule({ | TSESTree.PropertyDefinition | TSESTree.TSAbstractPropertyDefinition, ): void { + if (propertyDefinition.key.type === AST_NODE_TYPES.PrivateIdentifier) { + return; + } + const nodeType = 'class property'; const { name: propertyName } = util.getNameFromMember( diff --git a/packages/eslint-plugin/tests/rules/explicit-member-accessibility.test.ts b/packages/eslint-plugin/tests/rules/explicit-member-accessibility.test.ts index 4f2951c6d91..2c3a5a86eb7 100644 --- a/packages/eslint-plugin/tests/rules/explicit-member-accessibility.test.ts +++ b/packages/eslint-plugin/tests/rules/explicit-member-accessibility.test.ts @@ -342,7 +342,7 @@ class Test { #bar() {} } `, - options: [{ accessibility: 'no-public' }], + options: [{ accessibility: 'explicit' }], }, ], invalid: [