Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: wrong example in no-unnecessary-boolean-literal-compare #8980

Closed
2 tasks done
heitorlisboa opened this issue Apr 23, 2024 · 0 comments · Fixed by #8981
Closed
2 tasks done

Docs: wrong example in no-unnecessary-boolean-literal-compare #8980

heitorlisboa opened this issue Apr 23, 2024 · 0 comments · Fixed by #8981
Labels
accepting prs Go ahead, send a pull request that resolves this issue documentation Documentation ("docs") that needs adding/updating

Comments

@heitorlisboa
Copy link
Contributor

Before You File a Documentation Request Please Confirm You Have Done The Following...

Suggested Changes

According to issue #6897, the Comparison column in the no-unnecessary-boolean-literal-compare docs was missing an !( ... ) negation around the cases that were comparing nullable boolean variables to false, which was fixed by PR #6968.

One thing that went unnoticed, though, was that the example for the allowComparingNullableBooleansToFalse option is also missing the !( ... ) negation, which makes it incorrect.

Affected URL(s)

https://typescript-eslint.io/rules/no-unnecessary-boolean-literal-compare#allowcomparingnullablebooleanstofalse
@heitorlisboa heitorlisboa added documentation Documentation ("docs") that needs adding/updating triage Waiting for maintainers to take a look labels Apr 23, 2024
@heitorlisboa heitorlisboa mentioned this issue Apr 23, 2024
Merged
3 tasks
@kirkwaiblinger kirkwaiblinger added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for maintainers to take a look labels Apr 26, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fix no-unnecessary-boolean-literal-compare example heitorlisboa/typescript-eslint
2 participants
@kirkwaiblinger @heitorlisboa