Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [disable-type-checked-config] add rule #8954

Closed
wants to merge 3 commits into from
Closed

chore: [disable-type-checked-config] add rule #8954

wants to merge 3 commits into from

Conversation

OlivierZal
Copy link

@OlivierZal OlivierZal commented Apr 19, 2024 •
edited

PR Checklist

Overview

@typescript-eslint/explicit-function-return-type is a typed rule and then should belong to the disableTypeChecked config.

In particular this rule does not make sense for .js files.

@OlivierZal
Disable explicit-function-return-type rule in disableTypeChecked …
44b65bc 
…config

`@typescript-eslint/explicit-function-return-type` is a typed rule and then should belong to the `disableTypeChecked` config.

In particular this rule does not make sense for `.js` files.
@OlivierZal
Merge pull request #1 from OlivierZal/disable-type-checked-config/dis…
e67c349 
…able-typed-rule

Disable `explicit-function-return-type` rule in `disableTypeChecked` …
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @OlivierZal!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Apr 19, 2024 •
edited

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 8cb6589
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6622f30e75419a0008f59498
😎 Deploy Preview https://deploy-preview-8954--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 19, 2024 •
edited

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8cb6589. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

🟥 Failed Commands
nx test eslint-plugin --coverage=false
✅ Successfully ran 30 targets

Sent with 💌 from NxCloud.

@OlivierZal OlivierZal changed the title Disable explicit-function-return-type rule in disableTypeChecked config fix(eslint-plugin): [disable-type-checked-config] add new rule Apr 19, 2024
@OlivierZal OlivierZal changed the title fix(eslint-plugin): [disable-type-checked-config] add new rule feat(eslint-plugin): [disable-type-checked-config] add new rule Apr 19, 2024
@OlivierZal OlivierZal changed the title feat(eslint-plugin): [disable-type-checked-config] add new rule chore: [disable-type-checked-config] add rule Apr 19, 2024
@bradzacher
Copy link
Member

is a typed rule

No, it isn't. It is a pure syntactic rule.
It only applies to files that support TS syntax, yes, but it's not a type-aware rule.

Additionally as per the big comment at the top of the file - that file is auto-generated - so any manual changes like this one will be lost.

Finally we ask that contributors file issues before making such changes so that they can be discussed first.

@bradzacher bradzacher closed this Apr 19, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[disable-type-checked-config] missing @typescript-eslint/explicit-function-return-type rule
2 participants
@OlivierZal @bradzacher