Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [restrict-plus-operands] check += #892

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #878

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Aug 21, 2019
@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #892 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #892      +/-   ##
==========================================
+ Coverage   94.23%   94.25%   +0.02%     
==========================================
  Files         126      126              
  Lines        5377     5379       +2     
  Branches     1510     1511       +1     
==========================================
+ Hits         5067     5070       +3     
  Misses        177      177              
+ Partials      133      132       -1
Impacted Files Coverage Δ
.../eslint-plugin/src/rules/restrict-plus-operands.ts 100% <100%> (+2.77%) ⬆️

@a-tarasyuk a-tarasyuk closed this Oct 24, 2019
@a-tarasyuk a-tarasyuk reopened this Nov 18, 2019
bradzacher
bradzacher previously approved these changes Nov 21, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this

@bradzacher
Copy link
Member

Hmm - I hate doing this, but technically this is a breaking feature change, could you please add an option for this check, that is off by default?

We can switch it to be on by default with the next major.

@bradzacher bradzacher added 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready awaiting response Issues waiting for a reply from the OP or another party labels Nov 21, 2019
@a-tarasyuk a-tarasyuk force-pushed the bug/878-restrict-plus-operands-doesnt-check-compound-assignment branch from 6f3ded5 to c6bd2ce Compare November 21, 2019 08:48
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Nov 21, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@bradzacher bradzacher changed the title feat(eslint-plugin): [restrict-plus-operands] check compound assignment feat(eslint-plugin): [restrict-plus-operands] check += Nov 21, 2019
@bradzacher bradzacher merged commit fa88cb9 into typescript-eslint:master Nov 21, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[restrict-plus-operands] Doesn't check compound assignment
2 participants