Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [no-extran-class] add allowWithDecorator opt #886

Conversation

a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented Aug 20, 2019

Fixes #812

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Aug 20, 2019
@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #886 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #886      +/-   ##
==========================================
+ Coverage   94.23%   94.23%   +<.01%     
==========================================
  Files         126      126              
  Lines        5376     5379       +3     
  Branches     1509     1510       +1     
==========================================
+ Hits         5066     5069       +3     
  Misses        177      177              
  Partials      133      133
Impacted Files Coverage Δ
...ges/eslint-plugin/src/rules/no-extraneous-class.ts 100% <100%> (ø) ⬆️

@a-tarasyuk a-tarasyuk closed this Oct 24, 2019
@a-tarasyuk a-tarasyuk reopened this Nov 16, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this.

one minor change, just for sanity checking.
Could you please add a test which is the inverse of the one you added.
I.e. invalid test - class with a decorator, allowWithDecorator: false

@bradzacher bradzacher added the 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready label Nov 19, 2019
bradzacher
bradzacher previously approved these changes Nov 19, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this

@bradzacher bradzacher changed the title feat(eslint-plugin): [no-extraneous-class] add allowWithDecorator option feat(eslint-plugin): [no-extran-class] add allowWithDecorator opt Nov 19, 2019
@bradzacher bradzacher merged commit f1ab9a2 into typescript-eslint:master Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-extraneous-class] add allowWithDecorator option
2 participants