New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [no-extran-class] add allowWithDecorator opt #886
feat(eslint-plugin): [no-extran-class] add allowWithDecorator opt #886
Conversation
Thanks for the PR, @a-tarasyuk! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint |
…r-to-no-extraneous-class
…r-to-no-extraneous-class
…r-to-no-extraneous-class
…r-to-no-extraneous-class
…r-to-no-extraneous-class
…r-to-no-extraneous-class
…r-to-no-extraneous-class
…r-to-no-extraneous-class
Codecov Report
@@ Coverage Diff @@
## master #886 +/- ##
==========================================
+ Coverage 94.23% 94.23% +<.01%
==========================================
Files 126 126
Lines 5376 5379 +3
Branches 1509 1510 +1
==========================================
+ Hits 5066 5069 +3
Misses 177 177
Partials 133 133
|
…r-to-no-extraneous-class
…r-to-no-extraneous-class
…r-to-no-extraneous-class
…r-to-no-extraneous-class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this.
one minor change, just for sanity checking.
Could you please add a test which is the inverse of the one you added.
I.e. invalid test - class with a decorator, allowWithDecorator: false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this
Fixes #812