Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Mention no-unused-private-class-members in no-unused-vars docs #8218

Open
2 tasks done
JoshuaKGoldberg opened this issue Jan 8, 2024 · 0 comments
Open
2 tasks done
Labels
accepting prs Go ahead, send a pull request that resolves this issue documentation Documentation ("docs") that needs adding/updating

Comments

@JoshuaKGoldberg
Copy link
Member

Before You File a Documentation Request Please Confirm You Have Done The Following...

Suggested Changes

Mentioned by @mrazauskas in Discord (https://discord.com/channels/1026804805894672454/1084238921677946992/1191427957558878328):

Reading documentation of @typescript-eslint/no-unused-vars one might have an impression that the rule is fully replacing TypeScript's noUnusedLocals. Perhaps it is worth mentioning that no-unused-private-class-members should be used as well to have all (?) what noUnusedLocals does? The advice is available here already (more visibility could be good idea): #4571 (comment)

Agreed. Let's update https://typescript-eslint.io/rules/no-unused-vars to also mention https://eslint.org/docs/latest/rules/no-unused-private-class-members.

Affected URL(s)

https://typescript-eslint.io/rules/no-unused-vars

@JoshuaKGoldberg JoshuaKGoldberg added documentation Documentation ("docs") that needs adding/updating accepting prs Go ahead, send a pull request that resolves this issue labels Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting prs Go ahead, send a pull request that resolves this issue documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Development

No branches or pull requests

1 participant