Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript-estree): expose a wrapper cache clearing function for advanced usecases #6476

Merged
merged 3 commits into from Feb 20, 2023

Conversation

bradzacher
Copy link
Member

PR Checklist

Overview

Previously we exposed two separate functions and there were a few caches that weren't covered.

This PR exposes a single cache clear function that wraps up all our cache clearers for easy nuking.

@bradzacher bradzacher added the enhancement New feature or request label Feb 16, 2023
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Feb 16, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5359a68. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Feb 16, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 5359a68
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63f31a369a6b0f0008809f13
😎 Deploy Preview https://deploy-preview-6476--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #6476 (34ef895) into main (c46c793) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 34ef895 differs from pull request most recent head 9fe72ef. Consider uploading reports for the commit 9fe72ef to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6476      +/-   ##
==========================================
+ Coverage   90.64%   90.65%   +0.01%     
==========================================
  Files         373      374       +1     
  Lines       12751    12765      +14     
  Branches     3752     3754       +2     
==========================================
+ Hits        11558    11572      +14     
  Misses        853      853              
  Partials      340      340              
Flag Coverage Δ
unittest 90.65% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/typescript-estree/src/clear-caches.ts 100.00% <100.00%> (ø)
...pt-estree/src/parseSettings/createParseSettings.ts 91.66% <100.00%> (+0.36%) ⬆️
...ipt-estree/src/parseSettings/resolveProjectList.ts 91.48% <100.00%> (+0.37%) ⬆️
...-plugin/src/rules/explicit-function-return-type.ts 97.95% <0.00%> (ø)

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Would be nice to document this somewhere.

clearGlobCache();
}

// TODO - delete this in next major
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracking ticket?

packages/typescript-estree/src/clear-caches.ts Outdated Show resolved Hide resolved
@bradzacher bradzacher merged commit d816496 into main Feb 20, 2023
@bradzacher bradzacher deleted the 6462-cache-clear branch February 20, 2023 06:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: repeated lints in the same process run out of memory
2 participants