Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ast-spec): a JSXEmptyExpression is not a possible JSXExpression #6321

Merged
merged 1 commit into from Jan 30, 2023
Merged

Conversation

MageJohn
Copy link
Contributor

@MageJohn MageJohn commented Jan 10, 2023

PR Checklist

Overview

As described in the linked issue, a JSXEmptyExpression node is only generated as the child of a JSXExpressionContainer node, and so cannot appear in the same place as a JSXExpression.

@nx-cloud
Copy link

nx-cloud bot commented Jan 10, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a18bab7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @MageJohn!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jan 10, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a18bab7
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63bd504623f0b90009bd6df2
😎 Deploy Preview https://deploy-preview-6321--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MageJohn MageJohn changed the title fix(ast-spec): JSXEmptyExpression is not a possible JSXExpression fix(ast-spec): a JSXEmptyExpression is not a possible JSXExpression Jan 10, 2023
@bradzacher bradzacher added the bug Something isn't working label Jan 30, 2023
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher merged commit 4b27777 into typescript-eslint:main Jan 30, 2023
@MageJohn MageJohn deleted the fix-6315 branch January 31, 2023 12:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The JSXExpression union incorrectly includes JSXEmptyExpression
2 participants